feat(repo-tools): output "All tests pass." on silent reporter success#880
Merged
feat(repo-tools): output "All tests pass." on silent reporter success#880
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
FUDCo
approved these changes
Mar 18, 2026
Contributor
FUDCo
left a comment
FUDCo
left a comment
There was a problem hiding this comment.
LGTM, though there's something disturbing about forcing the SilentReporter to speak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SilentReporterpreviously output nothing when all tests passed. This was confusing Claude. This PR makes it print a single confirmation line so robots looking for text output know that the run completed successfully.Summary
reportSummary: added anelsebranch that writesAll tests pass.\nto stdout when no files fail and there are no unhandled errorsreportSummaryunit tests: success case (verifies the stdout write), file failure case, and unhandled errors caseTesting
The new behavior is covered by unit tests that spy on
process.stdout.writefor the success path and spy onDotReporter.prototype.reportSummaryfor the failure paths.🤖 Generated with Claude Code
Note
Low Risk
Low risk: small, localized change to Vitest reporter output plus unit tests; only affects stdout messaging on fully passing runs.
Overview
SilentReporter.reportSummarynow printsAll tests pass.\nto stdout when there are no failed files/tasks and no unhandled errors, instead of staying completely silent.Adds unit coverage for the new success output and verifies the failure/error paths still delegate to
DotReporter.reportSummary.Written by Cursor Bugbot for commit 5b9ec23. This will update automatically on new commits. Configure here.